rickchengx commented on code in PR #16021:
URL:
https://github.com/apache/dolphinscheduler/pull/16021#discussion_r1604651862
##########
dolphinscheduler-extract/dolphinscheduler-extract-base/src/main/java/org/apache/dolphinscheduler/extract/base/client/NettyRemotingClient.java:
##########
@@ -54,7 +56,8 @@ public class NettyRemotingClient implements AutoCloseable {
private final Bootstrap bootstrap = new Bootstrap();
- private final ConcurrentHashMap<Host, Channel> channels = new
ConcurrentHashMap<>(128);
+ private final ReentrantLock channelsLock = new ReentrantLock();
+ private final Map<Host, Channel> channels = new ConcurrentHashMap<>();
Review Comment:
Overall LGTM, Is this initial capacity of 128 still needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
