ruanwenjun commented on code in PR #16038:
URL:
https://github.com/apache/dolphinscheduler/pull/16038#discussion_r1606888353
##########
dolphinscheduler-extract/dolphinscheduler-extract-base/src/main/java/org/apache/dolphinscheduler/extract/base/client/NettyRemotingClient.java:
##########
@@ -166,13 +166,10 @@ private Channel getOrCreateChannel(Host host) {
* @param host host
* @return channel
*/
- private Channel createChannel(Host host) {
+ Channel createChannel(Host host) {
try {
- ChannelFuture future;
- synchronized (bootstrap) {
Review Comment:
No need to lock when we want to create a channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
