unigof commented on code in PR #17170:
URL:
https://github.com/apache/dolphinscheduler/pull/17170#discussion_r2097755818
##########
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/model/TaskNode.java:
##########
@@ -99,13 +99,6 @@ public class TaskNode {
@JsonSerialize(using = JSONUtils.JsonDataSerializer.class)
private String params;
- /**
- * inner dependency information
- */
- @JsonDeserialize(using = JSONUtils.JsonDataDeserializer.class)
- @JsonSerialize(using = JSONUtils.JsonDataSerializer.class)
- private String preTasks;
-
Review Comment:
> This field is used by frontend in workflow definition and workflow
instance and task definition and task instance. You should change the frontend
too.
Maybe I miss some info and not found usage by frontend, could you give me an
example? @SbloodyS thank you~
e.g. I found the field `preTasks` used in task-node.ts and
`taskRelationJson` in definition/create/create/index.tsx, but maybe it is not
same with `preTasks` in class `TaskNode`. It represent task relation, but it is
not `TaskNode`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
