SbloodyS commented on code in PR #17427: URL: https://github.com/apache/dolphinscheduler/pull/17427#discussion_r2284958080
########## docs/docs/zh/contribute/development-environment-setup.md: ########## @@ -7,8 +7,8 @@ * [Git](https://git-scm.com/downloads) * [JDK](https://www.oracle.com/technetwork/java/javase/downloads/index.html): v1.8+ * [Maven](http://maven.apache.org/download.cgi): v3.5+ -* [Node](https://nodejs.org/en/download): v16.13+ (dolphinScheduler 版本低于 3.0, 请安装 node v12.20+) -* [Pnpm](https://pnpm.io/installation): v6.x +* [Node](https://nodejs.org/en/download): v16.0+ (dolphinScheduler 版本低于 3.0, 请安装 node v12.20+) Review Comment: ```suggestion * [Node](https://nodejs.org/en/download): v16.0+ ``` ########## docs/docs/en/contribute/development-environment-setup.md: ########## @@ -155,6 +155,14 @@ Install frontend dependencies and run it. > Note: You can see more detail about the frontend setting in [frontend > development](./frontend-development.md). +We recommend using the `pnpm` package manager to save disk space. If you have not yet installed `pnpm`, you can install it using the following command before running the front-end component: Review Comment: ```suggestion If you have not yet installed `pnpm`, you can install it using the following command before running the front-end component: ``` ########## docs/docs/zh/contribute/development-environment-setup.md: ########## @@ -150,6 +150,14 @@ DolphinScheduler 开发环境配置有两个方式，分别是standalone模式 > 注意：你可以在[frontend development](./frontend-development.md)里查看更多前端的相关配置 +建议使用`pnpm`包管理以节约磁盘空间，在运行前端组件前，如果你还没有安装`pnpm`，可以使用以下命令安装： Review Comment: ```suggestion 在运行前端组件前，如果你还没有安装`pnpm`，可以使用以下命令安装： ``` ########## docs/docs/en/contribute/development-environment-setup.md: ########## @@ -7,8 +7,8 @@ Before setting up the DolphinScheduler development environment, please make sure - [Git](https://git-scm.com/downloads) - [JDK](https://www.oracle.com/technetwork/java/javase/downloads/index.html): v1.8+ - [Maven](http://maven.apache.org/download.cgi): v3.5+ -- [Node](https://nodejs.org/en/download): v16.13+ (dolphinScheduler version is lower than 3.0, please install node v12.20+) -- [Pnpm](https://pnpm.io/installation): v6.x +- [Node](https://nodejs.org/en/download): v16.0+ (dolphinScheduler version is lower than 3.0, please install node v12.20+) Review Comment: ```suggestion - [Node](https://nodejs.org/en/download): v16.0+ ``` We don't need to do that since this is the latest version's doc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
