njnu-seafish commented on code in PR #17907:
URL:
https://github.com/apache/dolphinscheduler/pull/17907#discussion_r2866847113
##########
dolphinscheduler-ui/src/views/security/token-manage/components/use-modal.ts:
##########
@@ -44,7 +44,7 @@ export function useModal(
? (userStore.getUserInfo as UserInfoRes).id
: null
),
- expireTime: ref(Date.now()),
+ expireTime: null as number | Date | null,
Review Comment:
> We should unify this type.
This multi-type design pattern is a standard approach for handling dates and
times in Vue 3 + TypeScript projects. It fully accounts for end-to-end
compatibility across the entire data flow pipeline, representing a robust
solution that has been proven in practice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
