ruanwenjun commented on code in PR #17956:
URL:
https://github.com/apache/dolphinscheduler/pull/17956#discussion_r2889409637
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/validator/workflow/TriggerWorkflowRequestTransformer.java:
##########
@@ -23,13 +23,23 @@
import org.apache.dolphinscheduler.api.validator.ITransformer;
import org.apache.dolphinscheduler.dao.entity.WorkflowDefinition;
import org.apache.dolphinscheduler.dao.repository.WorkflowDefinitionDao;
+import org.apache.dolphinscheduler.plugin.task.api.enums.Direct;
+import org.apache.dolphinscheduler.plugin.task.api.model.Property;
import org.apache.dolphinscheduler.plugin.task.api.utils.PropertyUtils;
+import org.apache.commons.collections.CollectionUtils;
+
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+
import lombok.extern.slf4j.Slf4j;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.stereotype.Component;
+import com.alibaba.druid.util.StringUtils;
Review Comment:
Use common utils.
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/validator/workflow/TriggerWorkflowRequestTransformer.java:
##########
@@ -64,4 +78,27 @@ public TriggerWorkflowDTO transform(WorkflowTriggerRequest
workflowTriggerReques
triggerWorkflowDTO.setWorkflowDefinition(workflowDefinition);
return triggerWorkflowDTO;
}
+
+ private void validateStartParamList(List<Property> startParamList) {
Review Comment:
You should do the validation work at `TriggerWorkflowDTOValidator`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
