ruanwenjun commented on code in PR #18071:
URL:
https://github.com/apache/dolphinscheduler/pull/18071#discussion_r2944105423
##########
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/executor/PhysicalTaskExecutor.java:
##########
@@ -87,6 +87,7 @@ public void updateTaskInstanceInfo(final int taskInstanceId) {
taskExecutorEventBus.publish(TaskExecutorRuntimeContextChangedLifecycleEvent.of(taskExecutor));
}
});
+
this.getTaskExecutionContext().setVarPool(this.physicalTask.getParameters().getVarPool());
Review Comment:
I would prefer to add this kind of lifecycle method at `AbstractTask`(maybe
names `ITaskPlugin` in the future).
I plan to refactor some of the TaskPlugin interfaces in version 3.5.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
