njnu-seafish commented on code in PR #18073:
URL:
https://github.com/apache/dolphinscheduler/pull/18073#discussion_r2964593146
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/DataSourceServiceImpl.java:
##########
@@ -417,9 +418,72 @@ public List<DataSource> authedDatasource(User loginUser,
Integer userId) {
}
@Override
- public List<ParamsOptions> getTables(Integer datasourceId, String
database) {
+ public List<ParamsOptions> getDatabases(User loginUser, Integer
datasourceId) {
Review Comment:
> Why change the method order, all you need is add a permission check.
Sorry, the database-table-column order feels more natural.
Fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
