SbloodyS commented on code in PR #18082:
URL:
https://github.com/apache/dolphinscheduler/pull/18082#discussion_r2966184091
##########
dolphinscheduler-master/pom.xml:
##########
@@ -307,6 +307,10 @@
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-to-slf4j</artifactId>
</exclusion>
+ <exclusion>
+ <groupId>com.vaadin.external.google</groupId>
+ <artifactId>android-json</artifactId>
+ </exclusion>
Review Comment:
I wrote it in PR description, and there are some warning in CI.
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/workflow/serial/AbstractSerialCommandHandler.java:
##########
@@ -86,6 +87,13 @@ public Void doInTransaction(TransactionStatus status) {
workflowInstance.setEndTime(DateUtils.getCurrentDate());
workflowInstance.setState(WorkflowExecutionStatus.STOP);
workflowInstanceDao.upsertWorkflowInstance(workflowInstance);
+ final Long workflowDefinitionCode =
+ serialCommand.getWorkflowDefinitionCode() != null
+ ? serialCommand.getWorkflowDefinitionCode()
+ : workflowInstance.getWorkflowDefinitionCode();
+ WorkflowInstanceMetrics.recordWorkflowInstanceFinish(
+ WorkflowExecutionStatus.STOP,
+ workflowDefinitionCode);
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
