norrishuang commented on PR #18069: URL: https://github.com/apache/dolphinscheduler/pull/18069#issuecomment-4172119952
Hi @SbloodyS, thanks for the review comments! I've addressed all three points: 1. **CI registration** — Added `EmrServerlessTaskAPITest` to `.github/workflows/api-test.yml` 2. **Failed case** — Added a failed workflow test case (`testEmrServerlessFailedWorkflowInstance`) with a dedicated WireMock mapping (`get-job-run-failed.json`). To avoid URL pattern conflicts between the success and failure scenarios, I used distinct `jobRunId`s (`test-job-run-id-success` / `test-job-run-id-failed`) with precise URL pattern matching, so WireMock routes each request deterministically. 3. **EMR version** — Updated `releaseLabel` to `emr-7.12.0` in the WireMock mock responses. All CI checks are now passing. Please take another look when you have a chance! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
