ruanwenjun commented on code in PR #18146:
URL:
https://github.com/apache/dolphinscheduler/pull/18146#discussion_r3061679577
##########
dolphinscheduler-master/src/test/java/org/apache/dolphinscheduler/server/master/integration/cases/WorkflowStartTestCase.java:
##########
@@ -360,7 +360,7 @@ public void
testStartWorkflow_with_oneSuccessTaskUsingEnvironmentConfig() {
Assertions
.assertThat(repository.queryWorkflowInstance(workflowInstanceId))
.matches(
- workflowInstance ->
workflowInstance.getState() == WorkflowExecutionStatus.SUCCESS);
+ workflowInstance ->
workflowInstance.getState() == WorkflowExecutionStatus.FAILURE);
Review Comment:
We may don't need to change this case?
##########
dolphinscheduler-master/src/test/resources/it/start/workflow_with_one_forbidden_condition_task_with_one_fake_predecessor_fatal.yaml:
##########
@@ -47,7 +47,6 @@ tasks:
taskType: LogicFakeTask
taskParams: '{"localParams":null,"varPool":[],"shellScript":"echo
success"}'
workerGroup: default
- environmentCode: 144873539254368
Review Comment:
We may don't need to change this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
