Mrhs121 commented on PR #18098: URL: https://github.com/apache/dolphinscheduler/pull/18098#issuecomment-4233535535
@ruanwenjun Thanks for the review. I summarized the feedback and these points make sense, I'll update. 1. Unify the API by adding a `logType` parameter instead of introducing separate task output endpoints. 2. Merge `LocalLogClient` into a single `getTaskLog(..., logType)` design for both full and paged queries. 3. Refactor task output logging to remove the empty-path check and dual-logger branching in `AbstractCommandExecutor`. 4. Keep `TaskLogType` lightweight and move task-instance-to-path resolution into a separate resolver/util class. 5. Change `task_output_log_path` from `longtext` to a bounded string type such as `varchar(255)` across all related SQL definitions. Regarding this idea :https://github.com/apache/dolphinscheduler/issues/17791#issuecomment-4230665843. My understanding is that the concern is not only about adding another file path field for task output, but also about the long-term storage model. Instead of storing separate file paths like log_path and task_output_log_path, a more extensible approach would be to store a single directory path such as task_out_path, and place all task-instance-generated files under it, for example log, output, and possibly other generated files in the future. maybe such as: * ${task_out_path}/task.log * ${task_out_path}/task.out * ${task_out_path}/stderr.log * ${task_out_path}/result.json -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
