ruanwenjun commented on code in PR #18164:
URL:
https://github.com/apache/dolphinscheduler/pull/18164#discussion_r3083561209
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/workflow/runnable/WorkflowExecutionRunnable.java:
##########
@@ -68,12 +66,6 @@ public List<IWorkflowLifecycleListener>
getWorkflowLifecycleListeners() {
return workflowInstanceLifecycleListeners;
}
- @Override
- public void
registerWorkflowInstanceLifecycleListener(IWorkflowLifecycleListener listener) {
Review Comment:
Don't remove this.
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/exception/LogicTaskInitializeException.java:
##########
@@ -23,8 +23,4 @@ public LogicTaskInitializeException(String message) {
super(message);
}
- public LogicTaskInitializeException(String message, Throwable cause) {
Review Comment:
Don't remove this.
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/workflow/runnable/IWorkflowExecutionRunnable.java:
##########
@@ -115,10 +115,5 @@ default IWorkflowExecutionGraph
getWorkflowExecutionGraph() {
*/
List<IWorkflowLifecycleListener> getWorkflowLifecycleListeners();
- /**
- * Register a WorkflowInstanceLifecycleListener to the Workflow instance.
- */
- void registerWorkflowInstanceLifecycleListener(IWorkflowLifecycleListener
listener);
Review Comment:
Don't remove this.
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/exceptions/TaskPauseException.java:
##########
@@ -19,10 +19,6 @@
public class TaskPauseException extends RuntimeException {
- public TaskPauseException(String message) {
Review Comment:
Don't remove this.
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/exceptions/TaskKillException.java:
##########
@@ -19,10 +19,6 @@
public class TaskKillException extends RuntimeException {
- public TaskKillException(String message) {
Review Comment:
Don't remove this.
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/exception/MasterTaskExecuteException.java:
##########
@@ -19,11 +19,8 @@
public class MasterTaskExecuteException extends MasterException {
- public MasterTaskExecuteException(String message) {
Review Comment:
Don't remove this.
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/exceptions/TaskReassignMasterHostException.java:
##########
@@ -19,10 +19,6 @@
public class TaskReassignMasterHostException extends RuntimeException {
- public TaskReassignMasterHostException(String message) {
Review Comment:
Don't remove this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
