ruanwenjun commented on PR #18068: URL: https://github.com/apache/dolphinscheduler/pull/18068#issuecomment-4317838508
Although I think the current approach is a bit difficult to maintain, I’ll look into how to optimize it later. Runtime instance parameters should be encapsulated within the master/worker engine; the API shouldn’t be aware of this parameter substitution logic, otherwise it would be too tightly coupled. Plus, if someone makes changes on the master side, they might not realize that the API also needs to be updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
