njnu-seafish commented on code in PR #18130:
URL:
https://github.com/apache/dolphinscheduler/pull/18130#discussion_r3239518309
##########
dolphinscheduler-master/src/main/resources/logback-spring.xml:
##########
@@ -51,6 +51,27 @@
</appender>
</sift>
</appender>
+
+ <appender name="WORKFLOWLOGFILE"
class="ch.qos.logback.classic.sift.SiftingAppender">
Review Comment:
> `rollingPolicy` should be added here.
Since the logs for a single task don't use the rolling policy, does that
mean the logs for a single workflow don't need it either?
Later, we'll need to add an entry point in the UI to view logs for a single
workflow. If we use the rolling policy, would that be inappropriate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
