hiSandog opened a new pull request, #18301:
URL: https://github.com/apache/dolphinscheduler/pull/18301

   ## Purpose
   
   `ClasspathSqlScriptParser` skips the initial block license header before 
parsing SQL resources. The closing marker check used the raw line, so a 
standard indented closing marker like ` */` was not recognized and the parser 
could skip the rest of the file.
   
   ## Changes
   
   - Trim the line before detecting the closing `*/` marker while skipping the 
license header.
   - Add a focused test SQL resource with an indented license header closing 
marker.
   - Cover the parser behavior in `ClasspathSqlScriptParserTest`.
   
   ## Verification
   
   - `git diff --cached --check`
   - Could not run `./mvnw -pl dolphinscheduler-common 
-Dtest=ClasspathSqlScriptParserTest test` because this machine has no Java 
Runtime available (`java -version` reports: Unable to locate a Java Runtime).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to