leocook commented on PR #18231: URL: https://github.com/apache/dolphinscheduler/pull/18231#issuecomment-4657688376
> You should check failed UT. @leocook Hi @SbloodyS, the failed CI is not caused by my code (this PR only changes 4 Java files) : 1. **`dead-link`** — repo-wide issue, `dev` is also red. Not mine. 2. **`milestone-label-check`** — need maintainer help: please set a milestone + add `bug` label, I have no permission. Thanks! 3. **`Unit Test`** — just a summary gate, will turn green after #4. 4. **`Unit-Test (master | Java 11)`** — a flaky test `WorkflowStartTimeoutTestCase.testStartWorkflow_withTimeoutKillTask`, nothing to do with my change. I checked locally: the case itself needs ~75s but the `await` window is only 90s, so under CI load it easily times out (Java 8 passed, Java 11 failed, same code). I'll push an empty commit to re-trigger. This flaky already exists on `dev`. Do you want me to open a separate issue + PR to fix it? Or just re-run is fine? Also the change you requested is already done — could you re-review to remove `CHANGES_REQUESTED`? Thanks a lot 🙏 @ruanwenjun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
