hutiefang76 opened a new pull request, #18365:
URL: https://github.com/apache/dolphinscheduler/pull/18365

   ## Purpose
   
   Close #18217.
   
   DataX custom parameters are rendered as `-Dkey='value'` inside the generated 
`-p` argument. When the value itself contains single quotes, for example a SQL 
condition with a timestamp literal, the generated shell command can be parsed 
incorrectly.
   
   ## Brief change log
   
   - Escape single quotes in DataX custom parameter values before building the 
command.
   - Add a regression test for a `ds_incr_condition` value containing quoted 
timestamp text.
   
   ## Verify this pull request
   
   - `JAVA_HOME=$(/usr/libexec/java_home -v 17) ./mvnw -pl 
dolphinscheduler-task-plugin/dolphinscheduler-task-datax -am 
-Dtest=DataxTaskTest -Dsurefire.failIfNoSpecifiedTests=false clean test`
   - `git diff --check`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to