github-advanced-security[bot] commented on code in PR #18385:
URL:
https://github.com/apache/dolphinscheduler/pull/18385#discussion_r3478786455
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/graph/WorkflowGraph.java:
##########
@@ -64,6 +67,53 @@
addTaskEdge(workflowTaskRelations);
}
+ private void checkIfDAG(List<WorkflowTaskRelation> workflowTaskRelations,
List<TaskDefinition> taskDefinitions) {
+ Map<Long, List<Long>> preTaskCodeMap = workflowTaskRelations
+ .stream()
+ .filter(relation -> relation.getPreTaskCode() > 0 &&
relation.getPostTaskCode() > 0)
+
.collect(Collectors.groupingBy(WorkflowTaskRelation::getPostTaskCode,
+
Collectors.mapping(WorkflowTaskRelation::getPreTaskCode, Collectors.toList())));
+ Map<Long, List<Long>> postTaskCodeMap = workflowTaskRelations
+ .stream()
+ .filter(relation -> relation.getPreTaskCode() > 0 &&
relation.getPostTaskCode() > 0)
+
.collect(Collectors.groupingBy(WorkflowTaskRelation::getPreTaskCode,
+
Collectors.mapping(WorkflowTaskRelation::getPostTaskCode,
Collectors.toList())));
+
+ Map<Long, Integer> inDegreeCount = new HashMap<>();
+ for (TaskDefinition taskDefinition : taskDefinitions) {
+ List<Long> preTasks = preTaskCodeMap.get(taskDefinition.getCode());
+ inDegreeCount.put(taskDefinition.getCode(), preTasks == null ? 0 :
preTasks.size());
+ }
+
+ Queue<Long> queue = new ArrayDeque<>();
+ for (Map.Entry<Long, Integer> entry : inDegreeCount.entrySet()) {
+ if (entry.getValue() == 0) {
+ queue.offer(entry.getKey());
Review Comment:
## CodeQL / Ignored error status of call
Method checkIfDAG ignores exceptional return value of Queue<Long>.offer.
[Show more
details](https://github.com/apache/dolphinscheduler/security/code-scanning/5807)
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/graph/WorkflowGraph.java:
##########
@@ -64,6 +67,53 @@
addTaskEdge(workflowTaskRelations);
}
+ private void checkIfDAG(List<WorkflowTaskRelation> workflowTaskRelations,
List<TaskDefinition> taskDefinitions) {
+ Map<Long, List<Long>> preTaskCodeMap = workflowTaskRelations
+ .stream()
+ .filter(relation -> relation.getPreTaskCode() > 0 &&
relation.getPostTaskCode() > 0)
+
.collect(Collectors.groupingBy(WorkflowTaskRelation::getPostTaskCode,
+
Collectors.mapping(WorkflowTaskRelation::getPreTaskCode, Collectors.toList())));
+ Map<Long, List<Long>> postTaskCodeMap = workflowTaskRelations
+ .stream()
+ .filter(relation -> relation.getPreTaskCode() > 0 &&
relation.getPostTaskCode() > 0)
+
.collect(Collectors.groupingBy(WorkflowTaskRelation::getPreTaskCode,
+
Collectors.mapping(WorkflowTaskRelation::getPostTaskCode,
Collectors.toList())));
+
+ Map<Long, Integer> inDegreeCount = new HashMap<>();
+ for (TaskDefinition taskDefinition : taskDefinitions) {
+ List<Long> preTasks = preTaskCodeMap.get(taskDefinition.getCode());
+ inDegreeCount.put(taskDefinition.getCode(), preTasks == null ? 0 :
preTasks.size());
+ }
+
+ Queue<Long> queue = new ArrayDeque<>();
+ for (Map.Entry<Long, Integer> entry : inDegreeCount.entrySet()) {
+ if (entry.getValue() == 0) {
+ queue.offer(entry.getKey());
+ }
+ }
+
+ Set<Long> sortedTaskCodes = new HashSet<>();
+ while (!queue.isEmpty()) {
+ Long taskCode = queue.poll();
+ sortedTaskCodes.add(taskCode);
+
+ List<Long> postCodes = postTaskCodeMap.get(taskCode);
+ if (postCodes == null) {
+ continue;
+ }
+ for (Long postCode : postCodes) {
+ inDegreeCount.put(postCode, inDegreeCount.get(postCode) - 1);
+ if (inDegreeCount.get(postCode) == 0) {
+ queue.offer(postCode);
Review Comment:
## CodeQL / Ignored error status of call
Method checkIfDAG ignores exceptional return value of Queue<Long>.offer.
[Show more
details](https://github.com/apache/dolphinscheduler/security/code-scanning/5808)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
