njnu-seafish commented on code in PR #18392: URL: https://github.com/apache/dolphinscheduler/pull/18392#discussion_r3528562712
########## dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/PluginDefineMapper.xml: ########## @@ -19,7 +19,7 @@ <!DOCTYPE mapper PUBLIC "-//mybatis.org//DTD Mapper 3.0//EN" "http://mybatis.org/dtd/mybatis-3-mapper.dtd"; > <mapper namespace="org.apache.dolphinscheduler.dao.mapper.PluginDefineMapper"> <select id="checkTableExist" resultType="int"> - select count(*) from information_schema.TABLES where table_name = 't_ds_plugin_define' + select count(*) from information_schema.tables where table_name = 't_ds_plugin_define' Review Comment: > Not all mysql will be case sensitive. This needs to distinguish between mysql and postgres. ok， will use database-specific SQL for plugin table check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
