njnu-seafish commented on PR #18404: URL: https://github.com/apache/dolphinscheduler/pull/18404#issuecomment-4924555002
@SbloodyS I noticed some inconsistencies in the naming and placement of the test classes while looking through the code. The service tests in the `dolphinscheduler-api` module currently have inconsistent naming and package placement. Most tests are placed under `org.apache.dolphinscheduler.api.service`, but they directly test implementation classes such as `UsersServiceImpl`, `ProjectServiceImpl`, and `QueueServiceImpl`. Meanwhile, a few similar tests are placed under `org.apache.dolphinscheduler.api.service.impl`. The class names are also inconsistent: some use the `XxxServiceImplTest` pattern, while most use `XxxServiceTest` even though they test `XxxServiceImpl` directly. This makes the test structure harder to navigate and maintain. Would it be worth standardizing these tests by moving service implementation tests under `api.service.impl` and renaming them to `XxxServiceImplTest`? <img width="2065" height="1179" alt="PM38SQJQO`A$)P6M`F3_WS4" src="https://github.com/user-attachments/assets/6317d89c-4399-40d7-a9b9-1068e848d41d"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
