hiSandog opened a new pull request, #18413: URL: https://github.com/apache/dolphinscheduler/pull/18413
## Was this PR generated or assisted by AI? YES. Codex assisted with identifying the indexing bug, implementing the fix, and adding the regression test. ## Purpose of the pull request The Windows net user parser checks charAt(i) inside a loop over j. A line that starts with a hyphen can therefore be misclassified as the all-hyphen separator, causing header text to be returned as usernames. The parser also needs to handle the CRLF output preserved by ShellExecutor. ## Brief change log - Check each separator character using the loop index. - Split command output on platform-independent line boundaries. - Extract the parser for package-level testing and add a CRLF regression case. ## Verify this pull request This change added tests and can be verified as follows: - Added OSUtilsTest coverage for a non-separator hyphenated line followed by a CRLF-delimited Windows user list. - git diff --check passes. - The parser fixture was independently exercised locally and returned alice and bob. - Maven tests were not run locally because no Java runtime is installed in the environment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
