qiuyanjun888 commented on code in PR #18397:
URL:
https://github.com/apache/dolphinscheduler/pull/18397#discussion_r3570298152
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-dinky/src/main/java/org/apache/dolphinscheduler/plugin/task/dinky/DinkyTask.java:
##########
@@ -404,7 +402,8 @@ private JsonNode parse(String res) {
try {
result = mapper.readTree(res);
} catch (JsonProcessingException e) {
- log.error("dinky task submit failed with error", e);
+ log.error("dinky task response parse failed, responseLength: {},
errorType: {}",
Review Comment:
Fixed by throwing `DinkyTaskException` when the Dinky response cannot be
parsed. The exception only includes the response length and parser exception
type, and the regression test verifies explicit failure without exposing
sensitive response values.
Verification: `./mvnw -pl
dolphinscheduler-task-plugin/dolphinscheduler-task-dinky
-Dtest='DinkyLogSanitizerTest#testParseMalformedResponseFailsExplicitlyWithoutExposingRawResponse'
clean test` passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
