nikhiln64 commented on PR #18434: URL: https://github.com/apache/dolphinscheduler/pull/18434#issuecomment-5312621142
Good catch, you are right that the UI was stricter than the backend here. The absence check only treated empty, undefined and null as absent, so a whitespace only value reached utils.isJson and was rejected even with exactly one valid .json resource attached, which the worker would have accepted. I now derive inlineJsonAbsent from model.json being undefined or null or trimming to empty, before the json validation, so a blank inline json falls back to the attached resource the same way the backend isInlineJsonAbsent does with StringUtils.isBlank. Pushed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
