ruanwenjun commented on code in PR #18566:
URL:
https://github.com/apache/dolphinscheduler/pull/18566#discussion_r3809998138
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskDefinitionServiceImpl.java:
##########
@@ -362,6 +367,7 @@ public Long updateTaskWithUpstream(User loginUser, long
projectCode, long taskCo
notExistTaskCodes);
throw new ServiceException(Status.TASK_DEFINE_NOT_EXIST,
notExistTaskCodes);
}
+ taskDatasourcePermissionChecker.checkPermission(loginUser,
upstreamTaskDefinitionList);
Review Comment:
Good catch. `upstreamCodes` contains the complete relationship set, so
unchanged upstream tasks should not be revalidated here. I removed this check
and kept validation for the submitted task in `updateTask(...)`. The obsolete
endpoint will be removed separately in #18568.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
