ruanwenjun commented on issue #18570:
URL: 
https://github.com/apache/dolphinscheduler/issues/18570#issuecomment-5352347719

   Proposed fix: in `CommandEngine.bootstrapError`, search the full cause chain 
for `CommandDuplicateHandleException` (for example, 
`ExceptionUtils.throwableOfType(...)`) and return before entering the generic 
failure transaction. Add a regression test that reproduces the 
`CompletionException` wrapper from `CompletableFuture` and verifies that no 
workflow failure or error-command handling is triggered.
   
   This fixes the incorrect side effects of a duplicate attempt. It does not 
mean that the command handler itself runs twice: the losing master fails while 
deleting the command and does not reach the handler.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to