zhang-arvin commented on PR #18575: URL: https://github.com/apache/dolphinscheduler/pull/18575#issuecomment-5433041884
@SbloodyS Thanks for the detailed review! I have updated the PR description to follow the template. Regarding the VarPool concern — I understand your point about preserving upstream OUT parameters. However, the key insight is that legitimate upstream OUT parameters (e.g., from a shell task preceding the sub-workflow) are already passed through `commandParam.getCommandParams()`. The `workflowInstance.getVarPool()` accumulates ALL OUT parameters from the entire parent workflow, including sibling branches that have no dependency relationship with the sub-workflow task. Removing `workflowInstance.getVarPool()` from the merge therefore: 1. Preserves valid upstream OUT parameters (via commandParams) 2. Eliminates sibling branch parameter pollution 3. Prevents parameter duplication Could you take another look when you have a chance? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
