zhang-arvin commented on PR #18574: URL: https://github.com/apache/dolphinscheduler/pull/18574#issuecomment-5433103299
@SbloodyS Thanks for the review! I have: 1. Updated the PR description to follow the template 2. Updated `NetUtilsTest.testGetHostInKubernetesMode` — the last two test cases now stub `getHostAddress()` and assert the returned IP address. The last case also serves as an explicit regression test for Kubernetes Deployment pods where the hostname is short (no svc suffix). Please take another look when you have a chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
