SEPURI-SAI-KRISHNA commented on PR #18544:
URL:
https://github.com/apache/dolphinscheduler/pull/18544#issuecomment-5474995889
Thanks @xiangzihao for merging `dev` into the branch. That triggered the
first full CI run on this PR, and the result is green where it matters:
- `Unit-Test (dolphinscheduler-dao | Java 8)` — success
- `Unit-Test (dolphinscheduler-dao | Java 11)` — success
`dolphinscheduler-dao` is the only module this PR touches, and both runs
include the new
`TaskInstanceDaoImplTest` case. Build, CodeQL, E2E, all four cluster-tests
and all six schema-checks also passed.
One job is red, but it never reached a test:
```
Unit-Test (dolphinscheduler-spi | Java 8)
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-surefire-plugin:3.5.4:test
Could not transfer artifact
org.apache.maven.surefire:surefire-junit-platform:pom:3.5.4
from/to central (https://repo.maven.apache.org/maven2):
Remote host terminated the handshake: SSL peer shut down incorrectly
```
That is Maven Central dropping the TLS handshake while resolving a surefire
plugin POM, in a module this PR does not touch. Because the matrix is fail-fast
it then cancelled ten sibling jobs. Could someone re-run the failed jobs when
convenient? I don't have permission to do it myself.
@SbloodyS, whenever you have a moment: the query now follows the definition
you gave. It filters `flag = 1` so only the valid instance of each task code is
considered, and it joins on `max(id)` rather than on `end_time`, so the grouped
subquery returns exactly one row per task code by construction and a tie on
`end_time` can no longer produce a duplicate key. Happy to adjust further if
you would still prefer a different approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
