hiSandog commented on code in PR #18629: URL: https://github.com/apache/dolphinscheduler/pull/18629#discussion_r4036394754
########## dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/utils/LogUtilsTest.java: ########## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.dolphinscheduler.common.utils; + +import static org.junit.jupiter.api.Assertions.assertEquals; + +import org.apache.commons.lang3.StringUtils; + +import java.util.Arrays; +import java.util.Collections; + +import org.junit.jupiter.api.Test; + +class LogUtilsTest { + + @Test + void testRollViewLogLinesWithMultibyteCharacters() { + String line = StringUtils.repeat("δΈ", 22000); Review Comment: Fixed in 174727ea1d. Replaced the Chinese literals in LogUtilsTest with the ASCII Unicode escape `\u20AC`, preserving the three-byte UTF-8 test cases. All 3 LogUtilsTest tests and the module's Spotless check pass with JDK 8. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
