njnu-seafish commented on issue #18662: URL: https://github.com/apache/dolphinscheduler/issues/18662#issuecomment-5806802954
@SbloodyS Thanks for raising this point in the PR review. Let me clarify the actual behavior. The new schedule created by insertSchedule is always persisted with releaseState = OFFLINE and is not registered into the Quartz scheduler, so it cannot fire anything by itself. It only takes effect after the user explicitly goes it online via onlineScheduler. That "go online" path (doOnlineScheduler) keeps the workflow-level check — it still throws WORKFLOW_DEFINITION_NOT_RELEASE when the workflow definition is not ONLINE. So an offline workflow's schedule can never actually be triggered; the current design guard is not bypassed. The change only aligns insertSchedule with updateSchedule (which already allows offline workflows to save), and removes an unnecessary stricter check for the "configure a timer first, go online later" flow. But I'm happy to add a defensive guard in doOnlineScheduler/insertOrUpdateScheduleTask as well, if you prefer — or fall back to option (B) (disable the Timing button for offline workflows in the UI). Could you share which direction the community prefers? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
