chovy-3012 commented on PR #18658: URL: https://github.com/apache/dolphinscheduler/pull/18658#issuecomment-5882231960
> WorkflowDefinitionMapper.xml handles the field and direction fallbacks independently. Consequently, sortField=foo&sortOrder=asc produces update_time asc, id asc, whereas #18666 specifies update_time desc for unrecognized fields. Please apply the complete default ordering when sortField is invalid and cover this parameter combination. Thanks. The field and direction were two independent <choose> blocks, so sortField=foo&sortOrder=asc fell back to update_time for the field but still honored asc for the direction, yielding update_time asc, id asc instead of the complete default. Fixed by merging them into a single nested <choose> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
