CycloneBoy commented on pull request #3245: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3245#issuecomment-660792477
Yes,it would be better.i will fix it later today ---Original--- From: "Yichao Yang"<[email protected]> Date: Mon, Jul 20, 2020 09:34 AM To: "apache/incubator-dolphinscheduler"<[email protected]>; Cc: "LEI SHENG"<[email protected]>;"Author"<[email protected]>; Subject: Re: [apache/incubator-dolphinscheduler] [Fix-3240][worker] Cannot find a (Map) Key deserializer for type (#3245) @yangyichao-mango commented on this pull request. In dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/UdfFuncDeserializer.java: > + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.dolphinscheduler.dao.entity; + +import org.apache.dolphinscheduler.common.utils.JSONUtils; +import org.apache.dolphinscheduler.common.utils.StringUtils; +import com.fasterxml.jackson.databind.DeserializationContext; +import com.fasterxml.jackson.databind.KeyDeserializer; +import java.io.IOException; + +public class UdfFuncDeserializer extends KeyDeserializer { Hi, Good job. Because UdfFuncDeserializer is not used by a entity class, and just for UdfFunc KeyDeserializer, is it better to move this file as a static class in UdfFunc.java or JSONUtils.java? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
