yangyichao-mango commented on a change in pull request #3244:
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/3244#discussion_r457468313



##########
File path: 
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/registry/MasterRegistry.java
##########
@@ -83,19 +83,6 @@ public void registry() {
         String address = NetUtils.getHost();
         String localNodePath = getMasterPath();
         
zookeeperRegistryCenter.getZookeeperCachedOperator().persistEphemeral(localNodePath,
 "");
-        
zookeeperRegistryCenter.getZookeeperCachedOperator().getZkClient().getConnectionStateListenable().addListener(new
 ConnectionStateListener() {
-            @Override
-            public void stateChanged(CuratorFramework client, ConnectionState 
newState) {
-                if(newState == ConnectionState.LOST){
-                    logger.error("master : {} connection lost from zookeeper", 
address);
-                } else if(newState == ConnectionState.RECONNECTED){
-                    logger.info("master : {} reconnected to zookeeper", 
address);
-                    
zookeeperRegistryCenter.getZookeeperCachedOperator().persistEphemeral(localNodePath,
 "");
-                } else if(newState == ConnectionState.SUSPENDED){
-                    logger.warn("master : {} connection SUSPENDED ", address);
-                }
-            }
-        });

Review comment:
       > I think you are right. Solved.
   
   Hi,
   Please add the `master zk address` to log,  not the zk server info. 
   
   -------
   
   需要添加的应该是master的zk地址信息,不是zk server的信息。




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to