yangyichao-mango commented on a change in pull request #3382:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/3382#discussion_r464073806
##########
File path:
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/utils/ProcessUtils.java
##########
@@ -318,7 +308,7 @@ public static void cancelApplication(List<String> appIds,
Logger logger, String
Runtime.getRuntime().exec(runCmd);
} catch (Exception e) {
- logger.error("kill application error", e);
+ logger.error("kill application error : {}",e.getMessage(),e);
Review comment:
There is no necessary to change this.
If we use
```
logger.error("kill application error", e);
```
actually, it is the function of [1].
If we use
```
logger.error("kill application error : {}",e.getMessage(),e);
```
it will be the function[2]. So we do not need to change this.
[1]
[2]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
