CalvinKirs commented on a change in pull request #3427:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/3427#discussion_r467813853
##########
File path:
dolphinscheduler-remote/src/main/java/org/apache/dolphinscheduler/remote/codec/NettyDecoder.java
##########
@@ -55,15 +55,18 @@ protected void decode(ChannelHandlerContext ctx, ByteBuf
in, List<Object> out) t
case MAGIC:
checkMagic(in.readByte());
checkpoint(State.COMMAND);
+ break;
case COMMAND:
commandHeader.setType(in.readByte());
checkpoint(State.OPAQUE);
+ break;
case OPAQUE:
commandHeader.setOpaque(in.readLong());
checkpoint(State.BODY_LENGTH);
case BODY_LENGTH:
commandHeader.setBodyLength(in.readInt());
checkpoint(State.BODY);
+ break;
Review comment:
@gabrywu gabrywu gave some suggestions, maybe you can complete it. You
can refer to https://github.com/apache/incubator-dolphinscheduler/pull/2969
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
