gabrywu commented on a change in pull request #3728: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3728#discussion_r489236178
########## File path: sql/upgrade/1.3.3_schema/mysql/dolphinscheduler_ddl.sql ########## @@ -112,4 +112,42 @@ CALL uc_dolphin_T_t_ds_resources_un(); DROP PROCEDURE IF EXISTS uc_dolphin_T_t_ds_resources_un; +drop PROCEDURE if EXISTS uc_dolphin_T_t_ds_process_definition_A_is_parallel; +delimiter d// +CREATE PROCEDURE uc_dolphin_T_t_ds_process_definition_A_is_parallel() + BEGIN + IF NOT EXISTS (SELECT 1 FROM information_schema.COLUMNS + WHERE TABLE_NAME='t_ds_process_definition' + AND TABLE_SCHEMA=(SELECT DATABASE()) + AND COLUMN_NAME ='is_parallel') + THEN + alter table t_ds_process_definition add is_parallel tinyint default '1' comment '0:serial,1:parallel'; Review comment: please refer to the lastest SQL script. Because the ddl SQL will be run on different DBMS, such as MySQL,Postgresql, and so on, however, they might no support procedure. ########## File path: sql/upgrade/1.3.3_schema/mysql/dolphinscheduler_ddl.sql ########## @@ -112,4 +112,42 @@ CALL uc_dolphin_T_t_ds_resources_un(); DROP PROCEDURE IF EXISTS uc_dolphin_T_t_ds_resources_un; +drop PROCEDURE if EXISTS uc_dolphin_T_t_ds_process_definition_A_is_parallel; +delimiter d// +CREATE PROCEDURE uc_dolphin_T_t_ds_process_definition_A_is_parallel() + BEGIN + IF NOT EXISTS (SELECT 1 FROM information_schema.COLUMNS + WHERE TABLE_NAME='t_ds_process_definition' + AND TABLE_SCHEMA=(SELECT DATABASE()) + AND COLUMN_NAME ='is_parallel') + THEN + alter table t_ds_process_definition add is_parallel tinyint default '1' comment '0:serial,1:parallel'; Review comment: please refer to the lastest SQL script. Because the ddl SQL will be run on different DBMS, such as MySQL,Postgresql, and so on, however, they might not support procedure. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org