BoYiZhang commented on pull request #3899: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3899#issuecomment-708238586
> merge ok > > > > > @BoYiZhang > > > > > please solve the code smell problem > > > > > then another pr to dev branch is needed. > > > > > > > > > > > > fix code smell > > > > dev branch can merge 1.3.3 , No more repeat submission > > > > > > > > > it's better submit pr on dev in time, if not, it will take more time in the future. > > > > > > Now there are some differences between 1.3.3 and dev branch, especially with codestyle > > If two copies of the same PR are submitted, then it is very troublesome to review. > > What's your opinion? > > i think you can submit > > > > > > @BoYiZhang > > > > > please solve the code smell problem > > > > > then another pr to dev branch is needed. > > > > > > > > > > > > fix code smell > > > > dev branch can merge 1.3.3 , No more repeat submission > > > > > > > > > it's better submit pr on dev in time, if not, it will take more time in the future. > > > > > > Now there are some differences between 1.3.3 and dev branch, especially with codestyle > > If two copies of the same PR are submitted, then it is very troublesome to review. > > What's your opinion? > > you are right, there would be troublesome to review. but it will be more difficult to merge two branches in the future. > By contrast, it would be easier for us to merge the changes at the moment. ok this pr to dev branch .. https://github.com/apache/incubator-dolphinscheduler/pull/3908 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
