Segun-Ogundipe commented on pull request #4434:
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/4434#issuecomment-760145446


   Hi @dailidong, @CalvinKirs, the 10 code smell being reported by sonar are 
actually not code smells. Sonar is registering them as code smells because the 
value is being taken from a variable and sonar thinks the value is not a 
regular expression but it actually is. The tests for the EnterpriseWechatUtils 
file will fail if I follow sonar suggestions and replace the call to 
`replaceAll()` with `replace()`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to