CalvinKirs commented on a change in pull request #4491:
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/4491#discussion_r560208908



##########
File path: 
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java
##########
@@ -888,8 +887,8 @@ private boolean checkAndImportProcessDefinition(User 
loginUser, String currentPr
 
         //create process definition
         Integer processDefinitionId =
-                Objects.isNull(createProcessResult.get(PROCESSDEFINITIONID))
-                        ? null : 
Integer.parseInt(createProcessResult.get(PROCESSDEFINITIONID).toString());
+                Objects.isNull(createProcessResult.get(Constants.DATA_LIST))

Review comment:
       I think it would be better to keep the original one. PROCESSDEFINITIONID 
clearly expresses the field key to be obtained here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to