CalvinKirs commented on a change in pull request #4645:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/4645#discussion_r569433268
##########
File path:
dolphinscheduler-alert/src/main/java/org/apache/dolphinscheduler/alert/AlertServer.java
##########
@@ -129,9 +134,19 @@ private void runSender() {
if (alertPluginManager == null ||
alertPluginManager.getAlertChannelMap().size() == 0) {
logger.warn("No Alert Plugin . Can not send alert info. ");
} else {
- List<Alert> alerts = alertDao.listWaitExecutionAlert();
- alertSender = new AlertSender(alerts, alertDao,
alertPluginManager);
- alertSender.run();
+ InterProcessMutex mutex = null;
+ try {
+ mutex = zookeeperClient.getAlertLockPath();
+ mutex.acquire();
Review comment:
If zk goes down, will all alerts was sidelined?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
