gaojun2048 commented on a change in pull request #4586:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/4586#discussion_r570087606
##########
File path: pom.xml
##########
@@ -563,21 +563,18 @@
<groupId>org.sonatype.aether</groupId>
<artifactId>aether-api</artifactId>
<version>1.13.1</version>
- <scope>provided</scope>
Review comment:
Why change this "scope" ?
##########
File path: pom.xml
##########
@@ -563,21 +563,18 @@
<groupId>org.sonatype.aether</groupId>
<artifactId>aether-api</artifactId>
<version>1.13.1</version>
- <scope>provided</scope>
</dependency>
<dependency>
<groupId>io.airlift.resolver</groupId>
<artifactId>resolver</artifactId>
<version>1.5</version>
- <scope>provided</scope>
Review comment:
aether-api, resolver and asm only used in local development mode, used
to load the plug-in through maven to load the plug-in pom.xml file configured
in alert.properties to facilitate debugging during development. Not required
when the server deployment is running.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
