CalvinKirs commented on a change in pull request #4586:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/4586#discussion_r579912026
##########
File path:
dolphinscheduler-alert/src/test/java/org/apache/dolphinscheduler/alert/plugin/DolphinPluginLoaderTest.java
##########
@@ -55,6 +48,6 @@ public void testLoadPlugins() throws Exception {
throw new RuntimeException("load Alert Plugin Failed !", e);
}
-
Assert.assertNotNull(alertPluginManager.getAlertChannelFactoryMap().get("email
alert"));
+
Assert.assertNotNull(alertPluginManager.getAlertChannelFactoryMap().get("Email"));
Review comment:
The alert module does not depend on specific plug-in modules, so
defining constants here may not be a good solution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
