[GitHub] [incubator-dolphinscheduler] dddyszy commented on a change in pull request #4936: [Fix-4862][Server] Kill yarn application command won't be execute whe…

Tue, 09 Mar 2021 00:02:15 -0800 


dddyszy commented on a change in pull request #4936:
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/4936#discussion_r589956656



##########
File path: 
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/utils/ProcessUtils.java
##########
@@ -59,7 +59,7 @@
     /**
      * Expression of PID recognition in Windows scene
      */
-    private static final Pattern WINDOWSATTERN = Pattern.compile("(\\d+)");
+    private static final Pattern WINDOWSATTERN = 
Pattern.compile("\\((\\d+)\\)");

Review comment:
       
![image](https://user-images.githubusercontent.com/20266837/110423391-ec903900-80db-11eb-9786-ecc14ea33435.png)
   test result is like this,not contains "()".and if the threads should be 
excluded, "\w+\\\\((\d+)\\\\)" take effect，just like this
   
![image](https://user-images.githubusercontent.com/20266837/110423653-6aecdb00-80dc-11eb-9375-20d7e0d768d2.png)
   if you think the second one make sense,i'll fix it




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to