kyoty commented on a change in pull request #5557:
URL: https://github.com/apache/dolphinscheduler/pull/5557#discussion_r689561536
##########
File path:
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterExecThread.java
##########
@@ -323,6 +324,8 @@ private void executeComplementProcess() throws Exception {
}
// flow end
// execute next process instance complement data
+ ProcessDefinition processDefinition =
processService.findProcessDefineById(processDefinitionId);
Review comment:
@dailidong @JinyLeeChina @caoping6
It seems a same problem described in #5909
But it‘s btter not to modify at here.
I personally think that the problem comes in
[MasterExecThread.java#L977](https://github.com/apache/dolphinscheduler/blob/1887bde1ebf8249de153890e78d449582e3eaf4a/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterExecThread.java#L977)
aftert this:
`processInstance =
processService.findProcessInstanceById(processInstance.getId());`
the `processDefinition` variable in `ProcessInstance` woule be null.
```java
// ProcessInstance.java
/**
* process definition structure
*/
@TableField(exist = false)
private ProcessDefinition processDefinition;
```
##########
File path:
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterExecThread.java
##########
@@ -323,6 +324,8 @@ private void executeComplementProcess() throws Exception {
}
// flow end
// execute next process instance complement data
+ ProcessDefinition processDefinition =
processService.findProcessDefineById(processDefinitionId);
Review comment:
@dailidong @JinyLeeChina @caoping6
It seems a same problem described in #5909
But it‘s better not to modify at here.
I personally think that the problem comes in
[MasterExecThread.java#L977](https://github.com/apache/dolphinscheduler/blob/1887bde1ebf8249de153890e78d449582e3eaf4a/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterExecThread.java#L977)
aftert this:
`processInstance =
processService.findProcessInstanceById(processInstance.getId());`
the `processDefinition` variable in `ProcessInstance` woule be null.
```java
// ProcessInstance.java
/**
* process definition structure
*/
@TableField(exist = false)
private ProcessDefinition processDefinition;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
