kezhenxu94 commented on a change in pull request #7151:
URL: https://github.com/apache/dolphinscheduler/pull/7151#discussion_r761786525



##########
File path: dolphinscheduler-server/src/main/resources/config/install_config.conf
##########
@@ -76,19 +76,19 @@ apiServerPort="12345"
 # ---------------------------------------------------------
 # The type for the metadata database
 # Supported values: ``postgresql``, ``mysql``.
-dbtype="mysql"
+DATABASE_TYPE="mysql"
 
-# The <HOST>:<PORT> connection pair DolphinScheduler connect to the metadata 
database
-dbhost="192.168.xx.xx:3306"
+# Spring datasource driver-class-name
+SPRING_DATASOURCE_DRIVER_CLASS_NAME="com.mysql.jdbc.Driver"

Review comment:
       Let's remove this, because when `DATABASE_TYPE` is set, the driver class 
is set accordingly, and if we let the users to set these, they might set a 
wrong driver for the database type, example: set `com.mysql.jdbc.Driver` for 
PostgreSQL.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to