caishunfeng commented on a change in pull request #8111:
URL: https://github.com/apache/dolphinscheduler/pull/8111#discussion_r787317252
##########
File path:
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessTaskRelationServiceImpl.java
##########
@@ -546,11 +579,22 @@ private ProcessTaskRelationLog
setRelationLog(ProcessDefinition processDefinitio
}
return result;
}
+ updateProcessDefiniteVersion(loginUser, result, processDefinition);
+
processTaskRelation.setProcessDefinitionVersion(processDefinition.getVersion());
processTaskRelation.setPreTaskVersion(0);
processTaskRelation.setPreTaskCode(0L);
+ Date now = new Date();
+ processTaskRelation.setUpdateTime(now);
int update = processTaskRelationMapper.updateById(processTaskRelation);
- if (update == 0) {
+ processTaskRelation.setId(0);
Review comment:
why set id=0?
##########
File path:
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
##########
@@ -2196,7 +2196,36 @@ public int
switchProcessTaskRelationVersion(ProcessDefinition processDefinition)
processTaskRelationMapper.deleteByCode(processDefinition.getProjectCode(),
processDefinition.getCode());
}
List<ProcessTaskRelationLog> processTaskRelationLogList =
processTaskRelationLogMapper.queryByProcessCodeAndVersion(processDefinition.getCode(),
processDefinition.getVersion());
- return
processTaskRelationMapper.batchInsert(processTaskRelationLogList);
+ int batchInsert =
processTaskRelationMapper.batchInsert(processTaskRelationLogList);
+ if (batchInsert == 0) {
+ return Constants.EXIT_CODE_FAILURE;
+ } else {
+ int result = 0;
+ for (ProcessTaskRelationLog taskRelationLog :
processTaskRelationLogList) {
+ int switchResult =
switchTaskDefinitionVersion(taskRelationLog.getPostTaskCode(),
taskRelationLog.getPostTaskVersion());
Review comment:
Does it also need to be dealt with preTaskCode?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
