zhongjiajie commented on pull request #8085: URL: https://github.com/apache/dolphinscheduler/pull/8085#issuecomment-1016257731
> > > Sorry for replying later, but should we test edit data source, and also enter the invalid parameter to test the behavior? > > > > > > I thinks we should also catch expect error in our E2E, WDYT @kezhenxu94 > > Expected errors are asserted in our existing tests, for example: creating a duplicate user/tenant that is already existing will assert an error I know that, I mean in this case, in datasource, we should also assert error expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
