caishunfeng commented on a change in pull request #8449:
URL: https://github.com/apache/dolphinscheduler/pull/8449#discussion_r810485593
##########
File path:
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java
##########
@@ -1662,6 +1662,18 @@ private void killAllTasks() {
this.addStateEvent(stateEvent);
}
}
+
+ if (this.stateWheelExecuteThread.clearTaskRetryList()) {
Review comment:
Why clear retry task list here? The relationship between
StateWheelExecuteThread and WorkflowExecuteThread is 1:N, so it can not clear
here for some one WorkflowExecuteThread.
##########
File path:
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/StateWheelExecuteThread.java
##########
@@ -331,14 +332,6 @@ private void addTaskStateChangeEvent(TaskInstance
taskInstance) {
workflowExecuteThreadPool.submitStateEvent(stateEvent);
}
- private void addProcessStopEvent(ProcessInstance processInstance) {
Review comment:
It seems OK, why do you have to move this function into
WorkflowExecuteThread?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
