guoshupei opened a new issue #8810:
URL: https://github.com/apache/dolphinscheduler/issues/8810


   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and 
found no similar issues.
   
   
   ### What happened
   
   In `EventExecuteService`class, If an exception is throw in the `onSuccess` 
method, then `eventHandlerMap`  (the dev branch is `multiThreadFilterMap`)  
cannot remove the thread of  `WorkflowExecuteThread` normally, which has two 
effects: 1)The `WorkflowExecuteThread` will not handle any events, so 
processInstance state does not change; 2. There is a risk of memory leak. 
   
   Also, I found that exceptions in the `onSuccess` method do not print out 
logs, making it difficult to locate the problem
   
   
![image](https://user-images.githubusercontent.com/29919212/157623159-30f6aa2b-0864-4e08-90d6-5a01246984c5.png)
   
   > 
   
   ### What you expected to happen
   
   The state of `ProcessInstance`changes normally
   
   ### How to reproduce
   
   In the `onSuccess` method throw an exception, can reproduce.
   
   Note: 
   1. You need to print `eventHandlerMap`and will find that 
`WorkflowExecuteThread` is always held and will not be removed
   2. You won't see any exception messages in the master log
   
   ### Anything else
   
   _No response_
   
   ### Version
   
   2.0.1
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to